Add Vary header for resource/files fetch operations
#4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivergrabinski
changed the title
Vary header for resource/files fetch operationsVary header for resource/files fetch operations
olivergrabinski
commented
Oct 5, 2023
Comment on lines
194
to
196
| private val unauthorizedOrNotFound: PartialFunction[FileRejection, Boolean] = { | ||
| case _: AuthorizationFailed | _: FileNotFound => true | ||
| } |
There was a problem hiding this comment.
It's necessary to do this as in the ResourcesRoutes. Without the rejection on AuthorizationFailed it will inject the Vary header into the errors.
There was a problem hiding this comment.
A better solution could be to improve the vary directive (as relying on rejection is not great) so as not to rely on respondWithHeaders as it is based on mapResponse:
def mapResponse(f: HttpResponse => HttpResponse): Directive0 =
mapRouteResultPF { case RouteResult.Complete(response) => RouteResult.Complete(f(response)) }We could have something like:
def mapSuccessResponse(f: HttpResponse => HttpResponse): Directive0 =
mapRouteResultPF { case RouteResult.Complete(response) if response.status.isSuccess => RouteResult.Complete(f(response)) }And build the vary directive on top of that
There was a problem hiding this comment.
That's better yes
imsdu
reviewed
Oct 5, 2023
| @@ -110,6 +110,13 @@ trait DeltaDirectives extends UriDirectives { | |||
| } | |||
| } | |||
|
|
|||
| /** Injects a `Vary: Accept,Accept-Encoding` into the response */ | |||
There was a problem hiding this comment.
DeltaDirectives is temporarily duplicated :)
olivergrabinski
force-pushed
the
vary-header
branch
from
9b68d48 to
6d323cc
Compare
imsdu
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4300
Closes #4299